Messages in this thread | | | Date | Fri, 4 Oct 2013 11:45:43 -0500 (CDT) | From | Ashley Lai <> | Subject | Re: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c) |
| |
On Fri, 4 Oct 2013, Jason Gunthorpe wrote:
> On Fri, Oct 04, 2013 at 05:50:01PM +0200, Peter H?we wrote: > >> I'm not 100% sure what's the usual procedure for module renames, especially >> since this is visible in userspace. >> >> For users the easiest way would be to rename tpm.c to tpm-core.c and >> leave the module name as it is. In git that's just a simple rename >> operation. > > I agree, keeping the old name seems much safer. > > I'm thinking of following the pattern seen in RTC. Rename tpm.c to > tpm-interface.c and eventually migrate all the driver model support > items into tpm-class.c. > > Does that seem good? I'll respin the patches and test modular rebuilds. > > Jason >
Me too, I vote to keep the same module name. Please let me know when you are done with this patch, I would like to test it out.
Thanks, --Ashley Lai
| |