lkml.org 
[lkml]   [2013]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED
    On Fri, 4 Oct 2013 10:09:09 +0200
    Peter Zijlstra <peterz@infradead.org> wrote:

    > On Fri, Sep 27, 2013 at 05:29:08PM +0200, Peter Zijlstra wrote:
    > > Subject: ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED
    > > From: Peter Zijlstra <peterz@infradead.org>
    > > Date: Fri Sep 27 17:11:00 CEST 2013
    > >
    > > Since we now have two need_resched states; trace the two so we can
    > > observe discrepancies.
    > >
    > > Cc: Steven Rostedt <rostedt@goodmis.org>
    > > Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    >
    > Steve, if you're done conferencing.. any objections?
    >

    Taking a quick look, my only objection so far is that the change log is
    rather flimsy. What are the two states and what are their dependencies?

    In other words, what does these flags in the trace actually mean?
    Probably need to add comments in the code and/or update the
    Documentation section

    -- Steve


    \
     
     \ /
      Last update: 2013-10-04 17:21    [W:6.538 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site