Messages in this thread | | | Date | Fri, 4 Oct 2013 14:44:43 +0900 | From | takasi-y@ops ... | Subject | Re: [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT |
| |
Hi Magnus, Thank you for your commnets.
> > +obj-$(CONFIG_ARCH_SHMOBILE) += shmobile/ > > +obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += shmobile/ > > Here I believe it is enough that you only use > CONFIG_ARCH_SHMOBILE_MULTI. ...
That is because it supports three configuration, 1. MULTI + KZM9D_REFERENCE + COMMON_CLK 2. KZM9D_REFERENCE + COMMON_CLK 3. KZM9D but,
> ... Building common clocks to coexist with the > old legacy board code does not make any sense IMO. ... I think so, too. And from the view of testing, having smaller variants is better. # easier :)
> > +ifeq ($(CONFIG_COMMON_CLK), y) > > +obj-$(CONFIG_ARCH_EMEV2) += clk-emev2.o > > +endif > > I don't think you would need the above ifeq/endif wrapper if you only > used CONFIG_ARCH_SHMOBILE_MULTI above. Right.
Anyway, because you have make kzm9d-reference things simpler, now we don't need to worry about it.
Thanks, /yoshii
| |