Messages in this thread Patch in this message | | | From | Soren Brinkmann <> | Subject | [PATCH 1/6] arm: zynq: platsmp: Fix CPU presence check | Date | Thu, 31 Oct 2013 09:10:14 -0700 |
| |
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Fix an off-by-one error in the logic that checks if a CPU is present. The ncores variable is a count of cores while the cpu variable is a 0 based index. So if ncores == cpu, cpu is out of range. Fix this comparison so non-existent CPUs are not probed.
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/arm/mach-zynq/platsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c index 689fbbc3d9c8..2512624e657d 100644 --- a/arch/arm/mach-zynq/platsmp.c +++ b/arch/arm/mach-zynq/platsmp.c @@ -39,7 +39,7 @@ int zynq_cpun_start(u32 address, int cpu) u32 trampoline_code_size = &zynq_secondary_trampoline_end - &zynq_secondary_trampoline; - if (cpu > ncores) { + if (cpu >= ncores) { pr_warn("CPU No. is not available in the system\n"); return -1; } -- 1.8.4.1
| |