lkml.org 
[lkml]   [2013]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] kvm: optimize out smp_mb using srcu_read_unlock
Il 30/10/2013 20:09, Michael S. Tsirkin ha scritto:
> I noticed that srcu_read_lock/unlock both have a memory barrier,
> so just by moving srcu_read_unlock earlier we can get rid of
> one call to smp_mb().
>
> Unsurprisingly, the gain is small but measureable using the unit test
> microbenchmark:
> before
> vmcall 1407
> after
> vmcall 1357
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Across how many runs? Best or average or "all runs were in that
ballpark", :) and what's the minimum/maximum before and after the patch?

As you say the benefit is not surprising, but the experiments should be
documented properly.

Paolo


\
 
 \ /
  Last update: 2013-10-31 13:01    [W:0.087 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site