Messages in this thread |  | | Date | Thu, 31 Oct 2013 09:50:31 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features |
| |
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote: > > feature_check needs to be invoked through call, and LDFLAGS may not be set > > so quotes are needed. > > and the problem is also when there's more than one option in LDFLAGS
yeah.
> > Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving > > me nuts with the upcoming timerfd feature detection. > > > > Signed-off-by: David Ahern <dsahern@gmail.com> > > Cc: Ingo Molnar <mingo@kernel.org> > > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Cc: Namhyung Kim <namhyung@kernel.org> > > Cc: Jiri Olsa <jolsa@redhat.com> > > Reviewed-and-tested-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
|  |