Messages in this thread |  | | Date | Wed, 30 Oct 2013 09:39:53 +0000 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [PATCH net-next RFC 3/5] xen-netback: Remove old TX grant copy definitons |
| |
>>> On 30.10.13 at 01:50, Zoltan Kiss <zoltan.kiss@citrix.com> wrote: > These became obsolate with grant mapping.
I didn't look at this in detail, but I'm surprised you can get away without any copying: For one, the header part needs copying anyway, so you'd pointlessly map and then copy it if it's small enough. And second you need to be prepared for the frontend to hand you more slots than you can fit in MAX_SKB_FRAGS (namely when MAX_SKB_FRAGS < XEN_NETIF_NR_SLOTS_MIN), which you can't handle with mapping alone afaict.
Jan
|  |