Messages in this thread Patch in this message | | | Date | Thu, 31 Oct 2013 10:52:21 +0800 | From | Chen Gang <> | Subject | [PATCH] fs/befs/linuxvfs.c: need signed cast for variable 'block' |
| |
Need signed cast for it, the original author assume the type of 'block' is long, so just cast to long. The related warnings (with allmodconfig):
fs/befs/linuxvfs.c:136:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- fs/befs/linuxvfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index daa15d6..27e5179 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -133,7 +133,7 @@ befs_get_block(struct inode *inode, sector_t block, befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", inode->i_ino, block); - if (block < 0) { + if ((long)block < 0) { befs_error(sb, "befs_get_block() was asked for a block " "number less than zero: block %ld in inode %lu", block, inode->i_ino); -- 1.7.7.6
| |