Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 0/2] make all stored entries accessible. | Date | Thu, 31 Oct 2013 00:24:56 +0000 |
| |
> So, do you mean efivars should fix to use the "id" in a proper way?
It would avoid the need for all these tests, and additions to the filename to guarantee uniqueness.
Not sure what options efivars has to create a unique, persistent "id" for each record. It's a fundamental part of how ERST works (though the unique ID is just based around a timestamp).
> I acked Madper's patch 2/2 earlier today, but when I look at your test result, I'm not sure if > it is reasonable for users to make multiple numbers visible to the file name. > >> -r--r--r-- 1 root root 17499 Oct 30 13:41 dmesg-erst-5940651313304961029--2129078373-1383165669
after I added the "count = 0" initialization the filename gets a tiny bit less scary:
-r--r--r-- 1 root root 17499 Oct 30 13:41 dmesg-erst-5940651313304961029-0-1383165669
-Tony
| |