lkml.org 
[lkml]   [2013]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clk: tegra: use pll_ref as the pll_e parent
On Wed, Oct 30, 2013 at 04:41:41PM +0100, Stephen Warren wrote:
> On 10/29/2013 06:41 PM, Peter De Schrijver wrote:
> > Use pll_ref instead of pll_re_vco as the pll_e parent on Tegra114 and
> > Tegra124. Also add a pll_ref table entry for pll_e for Tegra114.
>
> Why? What benefit does this give, or what bug does this fix?
>

Otherrwise Tegra114 will crash on boot.

> > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
>
> > val_aux = pll_readl(pll_params->aux_reg, pll);
> >
> > if (val & PLL_BASE_ENABLE) {
> > - if (!(val_aux & PLLE_AUX_PLLRE_SEL))
> > + if ((val_aux & PLLE_AUX_PLLRE_SEL) || (val_aux & val_aux))
>
> Isn't "|| (val_aux & val_aux)" always true, at least if the value is
> non-zero? Either this should be simply "|| val_aux", or one of those two
> "val_aux" is the wrong thing.
>

It should have been val_aux & PLLE_AUX_PLLP_SEL...

Cheers,

Peter.


\
 
 \ /
  Last update: 2013-10-30 23:41    [W:0.082 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site