Messages in this thread | | | Date | Wed, 30 Oct 2013 17:44:43 +0200 | From | Gleb Natapov <> | Subject | Re: [PATCH 1/4] kvm: Destroy & free KVM devices on release |
| |
On Wed, Oct 30, 2013 at 04:42:15PM +0100, Paolo Bonzini wrote: > Il 30/10/2013 16:33, Gleb Natapov ha scritto: > > > Hmm, ok. In that case I can drop this patch and I think the rest just > > > boils down to userspace use of the device. I had been close()'ing the > > > kvm device fd when all QEMU vfio devices are detached, but I can just as > > > easily leave it open in case a new device is added later. I'll send out > > > a new series after doing some more review and testing. Do you have any > > > comments on the rest of the series? Thanks, > > > > If I understand 4/4 correctly if there is VFIO device connected we > > assume non coherent domain. How hard it would be to do proper checking > > in this path series? > > Yes, that's my understanding as well. Is the performance impact measurable? > We grant a guest permission to call wbinvd() needlessly.
-- Gleb.
| |