Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL() | Date | Wed, 30 Oct 2013 12:57:45 +0000 |
| |
Chen Gang <gang.chen@asianux.com> wrote:
> If a macro is only used within 2 times, and also its contents are > within 2 lines, recommend to expand it to shrink code line. > > For our case, the macro is not portable either: some architectures' > assembler may use another character to mark newline in a macro (e.g. > '`' for arc), which will cause issue. > > If still want to use macro and let it portable enough, it will also > need include additional header file (e.g "#include <linux/linkage.h>", > although it also need be fixed).
Fine by me.
Applied.
| |