Messages in this thread | | | Date | Wed, 30 Oct 2013 12:38:50 +0000 | From | Matt Fleming <> | Subject | Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization |
| |
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote: > This reorganization: > > Adds 'attrsize' variable to make the code cleaner and more > understandable, replacing all 'sizeof(attributes)'. > > Removes 'bytes' prior assignment due this new approach. > > Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > fs/efivarfs/file.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-)
Hmm.. I'm not convinced this is much of an improvement. I think removing 'sizeof(attributes)' actually makes the code harder to read.
-- Matt Fleming, Intel Open Source Technology Center
| |