Messages in this thread | | | Date | Wed, 30 Oct 2013 13:20:50 +0200 | From | Gleb Natapov <> | Subject | Re: [PATCH] KVM: use a more sensible error number when debugfs directory creation fails |
| |
On Wed, Oct 30, 2013 at 12:17:32PM +0100, Paolo Bonzini wrote: > I don't know if this was due to cut and paste, or somebody was really > using a D20 to pick the error code for kvm_init_debugfs as suggested by > Linus (EFAULT is 14, so the possibility cannot be entirely ruled out). > Heh.
> In any case, this patch fixes it. > Acked-by: Gleb Natapov <gleb@redhat.com>
> Reported-by: Tim Gardner <tim.gardner@canonical.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index a9dd682cf5e3..1cf9ccb01013 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -3091,7 +3091,7 @@ static const struct file_operations *stat_fops[] = { > > static int kvm_init_debug(void) > { > - int r = -EFAULT; > + int r = -EEXIST; > struct kvm_stats_debugfs_item *p; > > kvm_debugfs_dir = debugfs_create_dir("kvm", NULL); > -- > 1.8.3.1
-- Gleb.
| |