Messages in this thread | | | Date | Thu, 3 Oct 2013 13:42:04 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] mm/sparsemem: Fix a bug in free_map_bootmem when CONFIG_SPARSEMEM_VMEMMAP |
| |
On Thu, 03 Oct 2013 11:32:02 +0800 Zhang Yanfei <zhangyanfei.yes@gmail.com> wrote:
> We pass the number of pages which hold page structs of a memory > section to function free_map_bootmem. This is right when > !CONFIG_SPARSEMEM_VMEMMAP but wrong when CONFIG_SPARSEMEM_VMEMMAP. > When CONFIG_SPARSEMEM_VMEMMAP, we should pass the number of pages > of a memory section to free_map_bootmem. > > So the fix is removing the nr_pages parameter. When > CONFIG_SPARSEMEM_VMEMMAP, we directly use the prefined marco > PAGES_PER_SECTION in free_map_bootmem. When !CONFIG_SPARSEMEM_VMEMMAP, > we calculate page numbers needed to hold the page structs for a > memory section and use the value in free_map_bootmem.
What were the runtime user-visible effects of that bug?
Please always include this information when fixing a bug.
| |