lkml.org 
[lkml]   [2013]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] perf tool: report user-friendly error from timechart
Ingo Molnar wrote:
>> + /* Perform a quick sanity check */
>> + if (!is_valid_tracepoint("power:cpu_frequency")) {
>> + fprintf(stderr, "Error:\tNo permissions to read $debugfs/tracing/events/power/cpu_frequency\n");
>> + fprintf(stderr, "Hint:\tChange the permissions of debugfs: /sys/kernel/debug\n");
>> + fprintf(stderr, "\tThe directory will be present if your kernel was compiled with debugfs support.\n");
>
> Is missing permissions the only way how is_valid_tracepoint() can fail?
>
> What if debugfs has the right permissions but CONFIG_TRACEPOINTS is
> disabled in the kernel?

I'm thinking about all this in terms of files present in debugfs. Will
the cpu_frequecy file be present if tracepoints is disabled? (should I
quickly check using User-Mode Linux?). If it won't be present, then we
can just change the last line to "compiled with debugfs and
tracepoints support".


\
 
 \ /
  Last update: 2013-10-03 15:01    [W:0.069 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site