Messages in this thread | | | Date | Tue, 29 Oct 2013 20:50:08 -0700 | Subject | Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int() | From | Cong Wang <> |
| |
On Tue, Oct 29, 2013 at 7:42 PM, David Miller <davem@davemloft.net> wrote: > From: David Mackey <tdmackey@booleanhaiku.com> > Date: Tue, 29 Oct 2013 15:16:38 -0700 > >> Using dev_kfree_skb_any() will resolve the below issue when a >> netconsole message is transmitted in an irq. > ... >> Signed-off-by: David Mackey <tdmackey@booleanhaiku.com> > > This is absolutely not the correct fix. > > The netpoll facility must invoke ->poll() in an environment which > is compatible, locking and interrupt/soft-interrupt wise, as that > in which it is normally called. >
Normally ->poll() is called in softirq context, while netpoll could be called in any context depending on its caller.
Also, netpoll disables IRQ for tx, which is another difference.
| |