Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 2/5] fat: add fat_fallocate operation | Date | Wed, 30 Oct 2013 10:27:25 +0900 |
| |
Namjae Jeon <linkinjeon@gmail.com> writes:
>>> + /* Release unwritten fallocated blocks on file release. */ >>> + if (round_up(inode->i_size, sb->s_blocksize) < >>> + MSDOS_I(inode)->i_disksize && inode->i_nlink != 0) >>> + fat_truncate_blocks(inode, inode->i_size); >>> + >>> truncate_inode_pages(&inode->i_data, 0); >>> if (!inode->i_nlink) { >>> inode->i_size = 0;
[...]
>> And inode->i_size should be ->mmu_private? > Sorry, I don't understand your question yet... > Could you elaborate more ?
"if" part is checking "round_up(->i_size) < ->i_disksize", but I guess fallocate() truncation should be only needed if there is uninitialized data. So, I felt that part should check ->mmu_private and ->i_disksize.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |