Messages in this thread | | | Date | Tue, 29 Oct 2013 20:24:39 +0100 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate |
| |
Dear Dan Williams,
On Tue, 29 Oct 2013 12:15:18 -0700, Dan Williams wrote:
> > I agree with Ezequiel, and I believe his patch is appropriate. The > > registers for the XOR engines are indeed split in two areas, so it > > makes sense to have this xor_base / xor_high_base split that reflects > > the register mapping passed from the Device Tree, and use this split in > > the macros used to access the registers. > > > > Ah ok, so it's a bug if an implementation ever puts the second > resource window at a non 0x200 offset.
Exactly.
Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |