Messages in this thread | | | Date | Tue, 29 Oct 2013 12:58:09 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH] cciss: return 0 from driver probe function on success, not 1 |
| |
On 10/29/2013 12:41 PM, Stephen M. Cameron wrote: > From: Stephen M. Cameron <scameron@beardog.cce.hp.com> > > A return value of 1 is interpreted as an error > > Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> > --- > drivers/block/cciss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index edfa251..0c004ac 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -5183,7 +5183,7 @@ reinit_after_soft_reset: > rebuild_lun_table(h, 1, 0); > cciss_engage_scsi(h); > h->busy_initializing = 0; > - return 1; > + return 0; > > clean4: > cciss_free_cmd_pool(h); >
How did this ever work?
-- Jens Axboe
| |