lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 12/81] drm/radeon: forever loop on error in radeon_do_test_moves()
    Date
    3.8.13.12 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 89cd67b326fa95872cc2b4524cd807128db6071d upstream.

    The error path does this:

    for (--i; i >= 0; --i) {

    which is a forever loop because "i" is unsigned.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/gpu/drm/radeon/radeon_test.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_test.c
    index fda09c9..91bec65 100644
    --- a/drivers/gpu/drm/radeon/radeon_test.c
    +++ b/drivers/gpu/drm/radeon/radeon_test.c
    @@ -37,8 +37,8 @@ static void radeon_do_test_moves(struct radeon_device *rdev, int flag)
    struct radeon_bo **gtt_obj = NULL;
    struct radeon_fence *fence = NULL;
    uint64_t gtt_addr, vram_addr;
    - unsigned i, n, size;
    - int r, ring;
    + unsigned n, size;
    + int i, r, ring;

    switch (flag) {
    case RADEON_TEST_COPY_DMA:
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-10-29 20:01    [W:4.034 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site