Messages in this thread | | | Date | Tue, 29 Oct 2013 16:04:37 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] irqchip: aramda370-xp: fix compilation warning |
| |
Vincent,
On Tue, 29 Oct 2013, Vincent Donnefort wrote:
Subject line : irqchip: aramda370-xp: fix compilation warning
We are not fixing compilation warnings. We modify the code so the compiler does not longer issue a warning.
> From: Vincent Donnefort <vdonnefort@gmail.com> > > Fix the following compilation warning: > drivers/irqchip/irq-armada-370-xp.c:55:23: warning: 'irq_controller_lock' defined but not used [-Wunused-variable] > > Signed-off-by: Vincent Donnefort <vdonnefort@gmail.com> > > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c > index bb328a3..75c3141 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -52,7 +52,9 @@ > #define IPI_DOORBELL_END (8) > #define IPI_DOORBELL_MASK 0xFF > > +#ifdef CONFIG_SMP > static DEFINE_RAW_SPINLOCK(irq_controller_lock); > +#endif
Instead of adding a new ifdeffery you should just move it into the existing #ifdef CONFIG_SMP section, which also contains the only usage site of irq_controller_lock
Thanks,
tglx
| |