Messages in this thread | | | Date | Tue, 29 Oct 2013 07:45:34 -0400 | From | Neil Horman <> | Subject | Re: [PATCH v3 3/3] msi: always unregister ->msi_kset within free_msi_irqs() |
| |
On Tue, Oct 29, 2013 at 11:30:32AM +0100, Veaceslav Falico wrote: > Currently we create and populate ->msi_kset while allocating irqs in > populate_msi_sysfs(), however if it fails and/or we want to free the > entries - we don't always remove it, and we might have problems if we've > failed to allocate irqs and try it again. > > To fix that, move the unregister part to free_msi_irqs() and remove already > existing ones. Also, verify if it was actually created - we don't always > call free_msi_irqs() after populate_msi_sysfs(). > > CC: Bjorn Helgaas <bhelgaas@google.com> > CC: Neil Horman <nhorman@tuxdriver.com> > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > CC: linux-pci@vger.kernel.org > CC: linux-kernel@vger.kernel.org > Signed-off-by: Veaceslav Falico <vfalico@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com>
| |