Messages in this thread | | | Date | Tue, 29 Oct 2013 10:54:08 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] x86: unify copy_from_user() size checking |
| |
* Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 26.10.13 at 12:31, Ingo Molnar <mingo@kernel.org> wrote: > > * Jan Beulich <JBeulich@suse.com> wrote: > >> I'd like to point out though that with __compiletime_object_size() > >> being restricted to gcc before 4.6, the whole construct is going to > >> become more and more pointless going forward. I would question > >> however that commit 2fb0815c9ee6b9ac50e15dd8360ec76d9fa46a2 ("gcc4: > >> disable __compiletime_object_size for GCC 4.6+") was really necessary, > >> and instead this should have been dealt with as is done here from the > >> beginning. > > > > Can we now revert 2fb0815c9ee6? > > Actually I'm afraid parisc would first need to follow the changes > done on x86 here, or else they'd run into (compile time) issues > (s390 and tile only emit warnings, i.e. would at worst suffer > cosmetically unless subtrees putting -Werror in place are > affected).
Given how trivial __compiletime_object_size() is, we could replicate a (differently named) copy of that in x86 uaccess.h?
This is something that would be pretty platform dependent anyway.
Thanks,
Ingo
| |