Messages in this thread | | | Date | Tue, 29 Oct 2013 12:34:30 +0400 | Subject | Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro | From | Max Filippov <> |
| |
On Tue, Oct 29, 2013 at 11:57 AM, Chen Gang <gang.chen@asianux.com> wrote: > On 10/28/2013 07:18 PM, Max Filippov wrote: >> Hi Chen, >> >> On Mon, Oct 28, 2013 at 2:30 PM, Chen Gang <gang.chen@asianux.com> wrote: >>> > For some toolchains, they use another character as newline in a macro >>> > (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >>> > macro) instead of ';' for it. >>> > Since "linux/export.h" are mainly used for exporting work, then our fix >>> > more likely belongs to "linux/linkage.h", and we need add the related >>> > checking in "linkage.h". >>> > >>> > Also need notice 80 columns wrap, and '\t' for each line. >>> > >>> > >>> > Signed-off-by: Chen Gang <gang.chen@asianux.com> >>> > --- >>> > arch/arc/include/asm/linkage.h | 2 + >>> > include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------ >> Actually vmlinux.lds.h is not an assembly code, but rather a linker script, >> later preprocessed by cpp. >> > > Consult: do xtensa also has its own ASM_NL?
It works well with common semicolon.
-- Thanks. -- Max
| |