Messages in this thread | | | Subject | Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types | From | Ben Hutchings <> | Date | Mon, 28 Oct 2013 04:51:25 +0000 |
| |
On Mon, 2013-10-28 at 00:26 -0400, David Miller wrote: > From: Ben Hutchings <ben@decadent.org.uk> > Date: Sun, 27 Oct 2013 21:51:44 +0000 > > > - dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len); > > + dbg(DBG_TX, "In fst_tx_dma %x %x %d\n", (u32)skb, mem, len); > > Please use %p for the skb pointer instead of casting it (which btw > will introduce a warning on 64-bit).
skb is the DMA address of the data in the sk_buff. Yes, this is really unusual naming.
Ben.
-- Ben Hutchings [W]e found...that it wasn't as easy to get programs right as we had thought. ... I realized that a large part of my life from then on was going to be spent in finding mistakes in my own programs. - Maurice Wilkes, 1949 [unhandled content-type:application/pgp-signature] | |