Messages in this thread | | | Date | Fri, 25 Oct 2013 15:37:45 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable |
| |
On Fri, Sep 06, 2013 at 10:38:00AM +0100, Lee Jones wrote: > On Fri, 06 Sep 2013, Sachin Kamat wrote: > > > Check the return value of regulator_enable to silence the following > > type of warnings: > > drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value > > of ‘regulator_enable’, declared with attribute warn_unused_result > > [-Wunused-result] > > > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Cc: Lee Jones <lee.jones@linaro.org> > > --- > > Compile tested. > > > > Changes since v2: > > * removed redundant assignment to false. > > Changes since v1: > > * converted dev_err and return to dev_warn as suggested by Lee Jones. > > --- > > > > drivers/power/ab8500_charger.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > Looks good now. > > Acked-by: Lee Jones <lee.jones@linaro.org>
Applied, thanks a lot for the patches and reviews!
Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |