lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support
On Wed, Oct 23, 2013 at 02:58:04PM +0200, Stephane Eranian wrote:

SNIP

> +
> +static void rapl_init_cpu(int cpu)
> +{
> + int i, phys_id = topology_physical_package_id(cpu);
> +
> + spin_lock(&rapl_hotplug_lock);
> +
> + /* check if phys_is is already covered */
> + for_each_cpu(i, &rapl_cpu_mask) {
> + if (phys_id == topology_physical_package_id(i))
> + return;

missing 'spin_unlock(&rapl_hotplug_lock)' above

> + }
> + /* was not found, so add it */
> + cpumask_set_cpu(cpu, &rapl_cpu_mask);
> +
> + spin_unlock(&rapl_hotplug_lock);
> +}
> +


\
 
 \ /
  Last update: 2013-10-25 15:01    [W:0.143 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site