Messages in this thread Patch in this message | | | From | Denis Efremov <> | Subject | [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null | Date | Fri, 25 Oct 2013 15:53:25 +0400 |
| |
ASSERT on args takes place after args dereference. This assertion is redundant since we are going to panic anyway.
Found by Linux Driver Verification project (linuxtesting.org) - PVS-Studio analyzer.
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com> --- fs/xfs/xfs_dir2_node.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c index 4c3dba7..dc814df 100644 --- a/fs/xfs/xfs_dir2_node.c +++ b/fs/xfs/xfs_dir2_node.c @@ -1366,7 +1366,6 @@ xfs_dir2_leafn_split( */ args = state->args; mp = args->dp->i_mount; - ASSERT(args != NULL); ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC); error = xfs_da_grow_inode(args, &blkno); if (error) { -- 1.8.3.1
| |