lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] skd: Replaced custom debug PRINTKs with pr_debug
On Thu, Oct 24 2013, Joe Perches wrote:
> On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote:
> > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote:
> > > Hi Jens,
> > >
> > > I'm resending the patch to replace custom debug macros with
> > > pr_debug(). Kindly please review and apply the patch. Thanking you.
> >
> > Thanks, that's a nice improvement. Applied.
>
> Is it really much of an improvement?
>
> It leaves possible different behavior with
> skdev->dbg_level/skd_dbg_level set without
> linkage to a few printks now.
>
> It also doesn't make use of dynamic debug's
> +f/+l capability to and always emits
> __func__/__LINE__.

It's an improvement from a private FOOPRINTK() macro. Feel free to send
in further improvements.

--
Jens Axboe



\
 
 \ /
  Last update: 2013-10-25 13:41    [W:0.062 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site