Messages in this thread | | | Date | Fri, 25 Oct 2013 15:30:33 +0530 | Subject | Re: [BUG 3.12.rc4] Oops: unable to handle kernel paging request during shutdown | From | Viresh Kumar <> |
| |
On 25 October 2013 15:40, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > And in my opinion acpi_cpufreq_init() should just return an error code if it > can't register the driver, like in the (untested) patch below. > > Rafael > > > --- > drivers/cpufreq/acpi-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-pm/drivers/cpufreq/acpi-cpufreq.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/acpi-cpufreq.c > +++ linux-pm/drivers/cpufreq/acpi-cpufreq.c > @@ -988,10 +988,10 @@ static int __init acpi_cpufreq_init(void > > /* don't keep reloading if cpufreq_driver exists */ > if (cpufreq_get_current_driver()) > - return 0; > + return -EEXIST; > > if (acpi_disabled) > - return 0; > + return -ENODEV; > > pr_debug("acpi_cpufreq_init\n");
Much better.. And probably the first return has caused the bug Linus faced..
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
| |