lkml.org 
[lkml]   [2013]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] pinctrl: tb10x: fix the error handling in tb10x_pinctrl_probe()
From
On Mon, Oct 21, 2013 at 4:55 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> This patch fix the error handling in tb10x_pinctrl_probe():
> - devm_ioremap_resource() return ERR_PTR() and never return NULL
> - remove the dev_err call to avoid redundant error message
> - pinctrl_register() returns NULL not ERR_PTR()
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks, patch applied!

Hm this seems to be an easy mistake to do. I have discussed
in the past whether we can make the compiler verify
error pointers semantically and warn on problems.

I don't know if that is achieveable though :-(

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-10-23 11:01    [W:0.075 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site