Messages in this thread | | | Date | Wed, 23 Oct 2013 10:45:18 +0200 | Subject | Re: [PATCH -next] pinctrl: tb10x: fix the error handling in tb10x_pinctrl_probe() | From | Linus Walleij <> |
| |
On Mon, Oct 21, 2013 at 4:55 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > This patch fix the error handling in tb10x_pinctrl_probe(): > - devm_ioremap_resource() return ERR_PTR() and never return NULL > - remove the dev_err call to avoid redundant error message > - pinctrl_register() returns NULL not ERR_PTR() > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, patch applied!
Hm this seems to be an easy mistake to do. I have discussed in the past whether we can make the compiler verify error pointers semantically and warn on problems.
I don't know if that is achieveable though :-(
Yours, Linus Walleij
| |