Messages in this thread | | | Date | Wed, 23 Oct 2013 21:31:12 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCHv4 2/3] Input: twl4030-pwrbutton: use dev_err for errors |
| |
On Wed, Oct 23, 2013 at 11:17:46AM -0700, Joe Perches wrote: > On Wed, 2013-10-23 at 19:54 +0200, Sebastian Reichel wrote: > > Use dev_err() to output errors instead of dev_dbg(). > [] > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > [] > > @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) > > > > pwr = input_allocate_device(); > > if (!pwr) { > > - dev_dbg(&pdev->dev, "Can't allocate power button\n"); > > + dev_err(&pdev->dev, "Can't allocate power button\n"); > > return -ENOMEM; > > } > > input_allocate_device uses kzalloc and it will emit a > standardized OOM message along with a dump_stack() > so this dev_err/dev_dbg is redundant and not necessary.
I saw you sent a big patchset changing this for all drivers. Should I drop this patch?
-- Sebastian [unhandled content-type:application/pgp-signature] | |