Messages in this thread | | | Date | Tue, 22 Oct 2013 14:32:23 +0400 | From | Stanislav Fomichev <> | Subject | Re: [PATCH] perf timechart: remove lock_depth from trace_entry |
| |
On Mon, Oct 07, 2013 at 02:48:34PM +0800, Chia-I Wu wrote: > struct trace_entry went out-of-sync with the kernel since > > commit b000c8065 "tracing: Remove the extra 4 bytes of padding in events" > > causing "perf timechart" to be broken. > > Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Stanislav Fomichev <stfomichev@yandex-team.ru>
For some reason nobody noticed this patch on lkml, so resending to the maintainers... This also makes sense to merge it into the stable line.
> --- > tools/perf/builtin-timechart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c > index c2e0231..f9cbc18 100644 > --- a/tools/perf/builtin-timechart.c > +++ b/tools/perf/builtin-timechart.c > @@ -303,7 +303,6 @@ struct trace_entry { > unsigned char flags; > unsigned char preempt_count; > int pid; > - int lock_depth; > }; > > #ifdef SUPPORT_OLD_POWER_EVENTS > -- > 1.8.3.1
| |