lkml.org 
[lkml]   [2013]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: intel-mid: add Merrifield platform support
On 10/22/2013 05:49 PM, Yang, Fei wrote:
> + if (intel_mid_identify_cpu() ==
> + INTEL_MID_CPU_CHIP_TANGIER) {
> + if (!strncmp(pentry->name,
> + "r69001-ts-i2c", 13))
> + /* active low */
> + irq_attr.polarity = 1;
> + else if (!strncmp(pentry->name,
> + "synaptics_3202", 14))
> + /* active low */
> + irq_attr.polarity = 1;
> + else if (irq == 41)
> + /* fast_int_1 */
> + irq_attr.polarity = 1;
>
> Do you really want to upstream these very hardware specific hacks? It's needed for
> Saltbay, but might not be correct for other Merrifield based hardware, if any.

At this very initial moment we do want to support saltbay, which is the
main reference for Merrifield. So we can't run away from the ugly hack :)
Later, when we upstream the support to detect specific intel mid board
details, this code will be isolated for saltbay (and maybe other
required boards) and won't affect Merrifield in general.

Br, David Cohen



\
 
 \ /
  Last update: 2013-10-23 05:01    [W:0.035 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site