Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 07/11] asmlinkage, module: Make ksymtab and kcrctab symbols and __this_module __visible | Date | Wed, 23 Oct 2013 11:39:09 +1030 |
| |
Andi Kleen <andi@firstfloor.org> writes: > From: Andi Kleen <ak@linux.intel.com> > > Make the ksymtab symbols for EXPORT_SYMBOL visible. > This prevents the LTO compiler from adding a .NUMBER prefix, > which avoids various problems in later export processing.
Applied, thanks.
Cheers, Rusty.
> Cc: rusty@rustcorp.com.au > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > include/linux/export.h | 4 ++-- > scripts/mod/modpost.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/export.h b/include/linux/export.h > index 412cd50..3f2793d 100644 > --- a/include/linux/export.h > +++ b/include/linux/export.h > @@ -43,7 +43,7 @@ extern struct module __this_module; > /* Mark the CRC weak since genksyms apparently decides not to > * generate a checksums for some symbols */ > #define __CRC_SYMBOL(sym, sec) \ > - extern void *__crc_##sym __attribute__((weak)); \ > + extern __visible void *__crc_##sym __attribute__((weak)); \ > static const unsigned long __kcrctab_##sym \ > __used \ > __attribute__((section("___kcrctab" sec "+" #sym), unused)) \ > @@ -59,7 +59,7 @@ extern struct module __this_module; > static const char __kstrtab_##sym[] \ > __attribute__((section("__ksymtab_strings"), aligned(1))) \ > = VMLINUX_SYMBOL_STR(sym); \ > - static const struct kernel_symbol __ksymtab_##sym \ > + __visible const struct kernel_symbol __ksymtab_##sym \ > __used \ > __attribute__((section("___ksymtab" sec "+" #sym), unused)) \ > = { (unsigned long)&sym, __kstrtab_##sym } > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 8247979..0971bac 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1853,7 +1853,7 @@ static void add_header(struct buffer *b, struct module *mod) > buf_printf(b, "\n"); > buf_printf(b, "MODULE_INFO(vermagic, VERMAGIC_STRING);\n"); > buf_printf(b, "\n"); > - buf_printf(b, "struct module __this_module\n"); > + buf_printf(b, "__visible struct module __this_module\n"); > buf_printf(b, "__attribute__((section(\".gnu.linkonce.this_module\"))) = {\n"); > buf_printf(b, "\t.name = KBUILD_MODNAME,\n"); > if (mod->has_init) > -- > 1.8.3.1
| |