Messages in this thread | | | Date | Mon, 21 Oct 2013 12:06:25 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] watchdog: Get rid of MODULE_ALIAS_MISCDEV statements |
| |
On Mon, Oct 21, 2013 at 05:38:49PM +0200, Jean Delvare wrote: > I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR) > and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements. > > Either the device is enumerated and the driver already has a module > alias (e.g. PCI, USB etc.) that will get the right driver loaded > automatically. > > Or the device is not enumerated and loading its driver will lead to > more or less intrusive hardware poking. Such hardware poking should be > limited to a bare minimum, so the user should really decide which > drivers should be tried and in what order. Trying them all in > arbitrary order can't do any good. > > On top of that, loading that many drivers at once bloats the kernel > log. Also many drivers will stay loaded afterward, bloating the output > of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets > loaded as a dependency) can't even be unloaded! > > If defining char-major-10-130 is needed then it should happen in > user-space. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Wim Van Sebroeck <wim@iguana.be> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Mike Frysinger <vapier.adi@gmail.com> > Cc: Wan ZongShun <mcuos.com@gmail.com> > Cc: Ben Dooks <ben-linux@fluff.org> > Cc: Kukjin Kim <kgene.kim@samsung.com> > Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk> > Cc: Jim Cromie <jim.cromie@gmail.com> > Cc: Guenter Roeck <linux@roeck-us.net>
Makes sense to me.
Acked-by: Guenter Roeck <linux@roeck-us.net>
| |