lkml.org 
[lkml]   [2013]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup
    Date
    When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't,
    emac_dev_mcast_set should only enable RX of multicasts and reset
    MACHASH registers.

    It does this, but afterwards it either sets up multicast MACs
    filtering or disables RX of multicasts and resets MACHASH registers
    again, rendering IFF_ALLMULTI flag useless.

    This patch fixes emac_dev_mcast_set, so that multicast MACs filtering and
    disabling of RX of multicasts are skipped when IFF_ALLMULTI flag is set.

    Tested with kernel 2.6.37.

    Signed-off-by: Mariusz Ceier <mceier+kernel@gmail.com>
    ---
    drivers/net/ethernet/ti/davinci_emac.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
    index 67df09e..6a32ef9 100644
    --- a/drivers/net/ethernet/ti/davinci_emac.c
    +++ b/drivers/net/ethernet/ti/davinci_emac.c
    @@ -876,8 +876,7 @@ static void emac_dev_mcast_set(struct net_device *ndev)
    netdev_mc_count(ndev) > EMAC_DEF_MAX_MULTICAST_ADDRESSES) {
    mbp_enable = (mbp_enable | EMAC_MBP_RXMCAST);
    emac_add_mcast(priv, EMAC_ALL_MULTI_SET, NULL);
    - }
    - if (!netdev_mc_empty(ndev)) {
    + } else if (!netdev_mc_empty(ndev)) {
    struct netdev_hw_addr *ha;

    mbp_enable = (mbp_enable | EMAC_MBP_RXMCAST);
    --
    1.8.4


    \
     
     \ /
      Last update: 2013-10-21 20:01    [W:4.611 / U:0.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site