| Date | Sun, 20 Oct 2013 22:43:16 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 03/19] perf record: Improve write_output error message |
| |
On Fri, Oct 18, 2013 at 03:29:00PM +0300, Adrian Hunter wrote: > Improve the error message from write_output() to say > what failed to write and give the error number. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > --- > tools/perf/builtin-record.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 92ca541..d269dfa 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -88,7 +88,7 @@ static int write_output(struct perf_record *rec, void *buf, size_t size) > int ret = write(rec->output, buf, size); > > if (ret < 0) { > - pr_err("failed to write\n"); > + pr_err("failed to write perf data, error: %m\n");
is this some kind of format magic? ;-) you wanted to print out 'ret' value, right?
jirka
|