lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/5] ARM: dts: Add dp-controller node to exynos5250-snow
    From
    On Tue, Oct 1, 2013 at 4:40 PM, Sean Paul <seanpaul@chromium.org> wrote:
    > This patch adds the dp-controller node to the exynos5250-snow board dts
    > file.
    >
    > Signed-off-by: Sean Paul <seanpaul@chromium.org>
    > ---
    > arch/arm/boot/dts/exynos5250-snow.dts | 12 ++++++++++++
    > 1 file changed, 12 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
    > index e5af3f2..780511a 100644
    > --- a/arch/arm/boot/dts/exynos5250-snow.dts
    > +++ b/arch/arm/boot/dts/exynos5250-snow.dts
    > @@ -190,6 +190,18 @@
    > samsung,vbus-gpio = <&gpx1 1 0>;
    > };
    >
    > + dp-controller {
    > + samsung,color-space = <0>;
    > + samsung,dynamic-range = <0>;
    > + samsung,ycbcr-coeff = <0>;
    > + samsung,color-depth = <1>;
    > + samsung,link-rate = <0x0a>;
    > + samsung,lane-count = <2>;
    > +
    > + pinctrl-names = "default";
    > + pinctrl-0 = <&dp_hpd>;
    > + };

    This won't actually do what I think you want. Since the dtsi has the
    node name "dp-controller@145B0000", you will end up duplicating a new
    node and not build on top of that one.

    There's two ways to do it: Always include the unit address, or create
    a label in the dtsi such that:

    dp_controller: dp-controller@ {....
    }

    Then in your dts you can, at the root level:

    &dp_controller {
    ... new stuff and overrides ...
    };



    -Olof


    \
     
     \ /
      Last update: 2013-10-02 23:41    [W:4.182 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site