Messages in this thread | | | Date | Wed, 2 Oct 2013 16:40:41 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT |
| |
On Wednesday 02 October 2013 04:10 PM, Linus Walleij wrote: > On Fri, Sep 27, 2013 at 6:06 PM, Stephen Warren <swarren@wwwdotorg.org> wrote: > Presumably given this, LinusW shouldn't have actually applied this > patch, since presumably it prevents any other driver from accepting > PIN_CONFIG_BIAS_DISABLE even in cases where it is appropriate? > There are many patches I shouldn't have applied ... > > Anyway I'm not quite following, this patch affected the Palmas > driver only I think so how can it prevent any other drivers from doing > the right thing? > > We'll just have to follow up with a patch that return -EINVAL for > PIN_CONFIG_BIAS_DISABLE I guess, Laxman is this what you're > doing now? >
Yes, I am going to remove this option so that it can fall to default where it says
dev_err(pci->dev, "Properties not supported\n"); return -ENOTSUPP;
Will post the patch soon.
Thanks, Laxman
| |