lkml.org 
[lkml]   [2013]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 02/13] uprobes: allow ignoring of probe hits
    On 10/15, David Long wrote:
    >
    > @@ -1732,9 +1732,6 @@ static void handle_swbp(struct pt_regs *regs)
    > return;
    > }
    >
    > - /* change it in advance for ->handler() and restart */
    > - instruction_pointer_set(regs, bp_vaddr);
    > -

    Well, this looks obviously wrong. This SET_IP() has the comment ;)

    Note also that with this breaks __skip_sstep() on x86.

    Oleg.



    \
     
     \ /
      Last update: 2013-10-19 19:21    [W:4.060 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site