Messages in this thread | | | Date | Thu, 17 Oct 2013 12:23:44 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] kmod: Run usermodehelpers only on cpus allowed for kthreadd |
| |
On Wed, 16 Oct 2013 22:37:52 +0000 Christoph Lameter <cl@linux.com> wrote:
> > > - /* We can run anywhere, unlike our parent keventd(). */ > > > - set_cpus_allowed_ptr(current, cpu_all_mask); > > > + /* We can run anywhere kthreadd can run */ > > > > This is a poor comment - it explains "what" (which was utterly obvious) > > but doesn't explain "why". The reader will want to know *why* > > call_usermodehelper() only runs on kthreadd CPUs, but we didn't tell > > him. > > We'd like to have the ability to avoid running usermodehelper on certain > cpus to avoid cpu holdoff situations? Would that we an acceptable > explanation? > > Or restricting kthreadd will also restrict usermodehelper spawning to > allow control for all spawned kernel threads?
Both, please ;)
| |