Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] virtio tools: use ansi versions of asm and volatile | Date | Wed, 16 Oct 2013 10:39:09 +1030 |
| |
Ramkumar Ramachandra <artagnon@gmail.com> writes: > asm and volatile are provided for backward compatibility; use the ansi > versions __asm__ and __volatile__.
Really? I don't see that in the gcc documentation. In fact, I didn't know __volatile__ at all:
If you are writing a header file that should be includable in ISO C programs, write `__asm__' instead of `asm'. *Note Alternate Keywords::.
We're not...
Cheers, Rusty.
> Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > --- > tools/virtio/asm/barrier.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtio/asm/barrier.h b/tools/virtio/asm/barrier.h > index aff61e1..b2fbbfc 100644 > --- a/tools/virtio/asm/barrier.h > +++ b/tools/virtio/asm/barrier.h > @@ -1,5 +1,5 @@ > #if defined(__i386__) || defined(__x86_64__) > -#define barrier() asm volatile("" ::: "memory") > +#define barrier() __asm__ __volatile__("" ::: "memory") > #define mb() __sync_synchronize() > > #define smp_mb() mb() > -- > 1.8.4.477.g5d89aa9
| |