Messages in this thread | | | Subject | Re: [PATCH 1/3] kexec: Add debug printing of kimage table entries | From | Joe Perches <> | Date | Tue, 15 Oct 2013 10:58:15 -0700 |
| |
On Tue, 2013-10-15 at 19:48 +0200, Geert Uytterhoeven wrote: > Print a list of pages to be copied if debugging is enabled. > Consecutive entries are merged to reduce screen clutter. [] > diff --git a/kernel/kexec.c b/kernel/kexec.c [] > +static void kimage_print_block(const struct kimage_block *block) > +{ > + pr_info("Copy from 0x%lx-0x%lx to 0x%lx-0x%lx (0x%lx bytes)\n", > + block->src, block->src + block->len - 1, block->dst, > + block->dst + block->len - 1, block->len); > +}
Perhaps pr_debug and this maybe nicer to read like:
pr_debug("kimage: Copy from 0x%lx-0x%lx to 0x%lx-0x%lx (0x%lx bytes)\n", block->src, block->src + block->len - 1, block->dst, block->dst + block->len - 1, block->len);
Using a "kimage: " prefix could help grep too.
| |