lkml.org 
[lkml]   [2013]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 12/12] intel_mid: Moved board related code to a new file
On 10/15/2013 04:53 PM, David Cohen wrote:
> On 10/15/2013 04:44 PM, H. Peter Anvin wrote:
>> On 10/15/2013 04:42 PM, David Cohen wrote:
>>>
>>> +#define intel_mid_sfi_dev(i) \
>>> + static const struct devs_id *__intel_mid_sfi_##i##_dev __used \
>>> + __attribute__((__section__(".x86_intel_mid_dev.init"))) = &i
>>> +
>>
>> Any reason to not just call this "sfi_device()" or something similar?
>> "Intel MID SFI" seems a bit redundant...
>
> I had the same though. But struct devs_id is defined by asm/intel-mid.h.
> This function is not meant to be used by any other user beside
> intel-mid.
> But I can change if you prefer.
>

Hm, I guess it doesn't really matter. After all, no other devices will
probably ever see SFI (we hope).

-hpa




\
 
 \ /
  Last update: 2013-10-16 03:01    [W:0.073 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site