lkml.org 
[lkml]   [2013]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH] usb-storage: scsiglue: Changing the command result
On Tue, 15 Oct 2013, Vishal Annapurve wrote:

> Hi Alan,
>
> This issue seems more related to the devices using SCSI protocol and the
> changes otherwise will be at more places giving the same end result.
>
> I think as the comment says over the command_abort function,
> intentional result change should only happen in case of timeout.

usb-storage doesn't know _why_ a command was aborted; it knows only
that the abort occurred.

If you look carefully at the code, you'll see that the result is set to
DID_ABORT only when the US_FLIDX_TIMED_OUT bit is set, and this bit
gets set only when a SCSI abort occurs.

Alan Stern



\
 
 \ /
  Last update: 2013-10-15 19:21    [W:0.097 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site