Messages in this thread | | | Date | Tue, 15 Oct 2013 13:02:43 -0400 (EDT) | From | Alan Stern <> | Subject | RE: [PATCH] usb-storage: scsiglue: Changing the command result |
| |
On Tue, 15 Oct 2013, Vishal Annapurve wrote:
> Hi Alan, > > This issue seems more related to the devices using SCSI protocol and the > changes otherwise will be at more places giving the same end result. > > I think as the comment says over the command_abort function, > intentional result change should only happen in case of timeout.
usb-storage doesn't know _why_ a command was aborted; it knows only that the abort occurred.
If you look carefully at the code, you'll see that the result is set to DID_ABORT only when the US_FLIDX_TIMED_OUT bit is set, and this bit gets set only when a SCSI abort occurs.
Alan Stern
| |