Messages in this thread | | | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 34/34] mm: dynamically allocate page->ptl if it cannot be embedded to struct page | Date | Tue, 15 Oct 2013 00:25:14 +0300 (EEST) |
| |
Christoph Lameter wrote: > On Mon, 14 Oct 2013, Kirill A. Shutemov wrote: > > > > > > Could you make the check a CONFIG option? CONFIG_PTLOCK_DOES_NOT_FIT_IN_PAGE_STRUCT or > > > > > so? > > > > > > > > No. We will have to track what affects sizeof(spinlock_t) manually. > > > > Not a fun and error prune. > > > > > > You can generate a config option depending on the size of the object via > > > Kbuild. Kbuild will determine the setting before building the kernel as a > > > whole by runing some small C program. > > > > I don't think it's any better than what we have there now. > > Well with the CONFIG options we can then create macros etc that handle > things differently depending on the ptl being in the page or not.
Feel free to propose a patch. I don't see much point.
-- Kirill A. Shutemov
| |