lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/14] sched: SCHED_DEADLINE structures & implementation.
On 10/14/2013 01:24 PM, Peter Zijlstra wrote:
> On Mon, Oct 14, 2013 at 12:43:35PM +0200, Juri Lelli wrote:
>> +/*
>> + * We are being explicitly informed that a new instance is starting,
>> + * and this means that:
>> + * - the absolute deadline of the entity has to be placed at
>> + * current time + relative deadline;
>> + * - the runtime of the entity has to be set to the maximum value.
>> + *
>> + * The capability of specifying such event is useful whenever a -deadline
>> + * entity wants to (try to!) synchronize its behaviour with the scheduler's
>> + * one, and to (try to!) reconcile itself with its own scheduling
>> + * parameters.
>> + */
>> +static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se)
>> +{
>> + struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
>> + struct rq *rq = rq_of_dl_rq(dl_rq);
>> +
>> + WARN_ON(!dl_se->dl_new || dl_se->dl_throttled);
>> +
>> + /*
>> + * We use the regular wall clock time to set deadlines in the
>> + * future; in fact, we must consider execution overheads (time
>> + * spent on hardirq context, etc.).
>> + */
>> + dl_se->deadline = rq->clock + dl_se->dl_deadline;
>> + dl_se->runtime = dl_se->dl_runtime;
>> + dl_se->dl_new = 0;
>> +}
>
> 78becc270975 sched: Use an accessor to read the rq clock
>
> wants you to use rq_clock(rq) there I think.
>
>

Modified here and below.

Thanks,

- Juri


\
 
 \ /
  Last update: 2013-10-14 17:21    [W:0.195 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site