lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/14] sched: SCHED_DEADLINE SMP-related data structures & logic.
    On Mon, Oct 14, 2013 at 12:43:36PM +0200, Juri Lelli wrote:
    > +static inline void dl_set_overload(struct rq *rq)
    > +{
    > + if (!rq->online)
    > + return;
    > +
    > + cpumask_set_cpu(rq->cpu, rq->rd->dlo_mask);
    > + /*
    > + * Must be visible before the overload count is
    > + * set (as in sched_rt.c).
    > + */
    > + wmb();
    > + atomic_inc(&rq->rd->dlo_count);
    > +}

    Please, make that smp_wmb() and modify the comment to point to the
    matching barrier ; I couldn't find one! Which suggests something is
    amiss.

    Ideally we'd have something like smp_wmb__after_set_bit() but alas.


    \
     
     \ /
      Last update: 2013-10-14 14:21    [W:3.097 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site